Convert brand store snaps to TypeScript #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4312 +/- ##
===========================================
- Coverage 87.56% 71.52% -16.05%
===========================================
Files 95 90 -5
Lines 6653 2975 -3678
Branches 0 770 +770
===========================================
- Hits 5826 2128 -3698
+ Misses 827 726 -101
- Partials 0 121 +121
Flags with carried forward coverage won't be shown. Click here to find out more. |
Lukewh
reviewed
Jun 28, 2023
| @@ -27,24 +27,38 @@ import SnapsSearch from "./SnapsSearch"; | |||
| import SectionNav from "../SectionNav"; | |||
| import StoreNotFound from "../StoreNotFound"; | |||
|
|
|||
| import type { BrandStores, Snap, Snaps, Members } from "../../types/shared"; | |||
|
|
|||
| // type Snaps = { | |||
steverydz
force-pushed
the
convert-snaps-to-typescript
branch
from
4aba6d3
to
3e46145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Converted the brand store snaps to TypeScript
How to QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-4853